feat(pill): added pill component #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled a new version demo. |
Pull Request Test Coverage Report for Build 3226452550
💛 - Coveralls |
Coverage report
Show new covered files 🐣
Test suite run success212 tests passing in 30 suites. Report generated by 🧪jest coverage report action from dff6c93 |
derek-heycar
suggested changes
Aug 24, 2022
There was a problem hiding this comment.
- SH tests
- use typography mixin for the fonts, according the template it should be
Subheader/Sub Header 3 - Med - provide all of the default HTML attributes to the components
- getting approve from DT
- check the link on the sigma template, I guess it's not correct.
- Could you check pls, is available multiline for this component ? Because I guess the height of the component should be constants 28px.
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
derek-heycar
suggested changes
Aug 29, 2022
derek-heycar
suggested changes
Aug 29, 2022
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
derek-heycar
suggested changes
Sep 23, 2022
|
Compiled a new version demo. |
|
Compiled a new version demo. |
added a pill component alongside tests to display information
fixed linting space issue in module.css file
# [2.1.0](v2.0.1...v2.1.0) (2022-10-10) ### Features * **icons:** added updated icons ([#89](#89)) ([5dad4af](5dad4af))
- @heycar-uikit/[email protected] - @heycar-uikit/[email protected] - @heycar-uikit/[email protected]
derek-heycar
suggested changes
Oct 10, 2022
derek-heycar
suggested changes
Oct 10, 2022
# [2.2.0](v2.1.0...v2.2.0) (2022-10-11) ### Features * **form-control:** improve documentation part ([ae8ff57](ae8ff57))
added a pill component alongside tests to display information
fixed linting space issue in module.css file
Fix pill component screenshot test update problem
…ttps://github.com/hey-car/hey-ui into feature/HEYUI-136-implementations-of-pill-component
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
hcafaq
deleted the
feature/HEYUI-136-implementations-of-pill-component
branch
derek-heycar
pushed a commit
that referenced
this pull request
Oct 25, 2022
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a pill component alongside tests to display information
Pull Request
Description
### Type of changeHow do I test this
import Pill from '@heycar-uikit/pill';
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:screenshots- to run snapshot testsNew Feature / Bug Fix
Thanks for contributing!