refactor(external_link): utilize hexo-util isExternalLink()

[SukkaW]

What does it do?

This is a performance test of hexojs/hexo-util#124 to see if #3839 is still necessary. If newer isExternalLink() works, #3839 should be superseded by #3835.

How to test

git clone -b test-utilize-hexo-util https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

• Add test cases for the changes.
• Passed the CI test.

[coveralls]

Coverage decreased (-0.03%) to 97.118% when pulling c1037f0 on SukkaW:test-utilize-hexo-util into 6fa7ada on hexojs:master.

[coveralls]

Coverage decreased (-0.03%) to 97.118% when pulling ebc42f0 on SukkaW:test-utilize-hexo-util into 6fa7ada on hexojs:master.

[SukkaW]

• Node.js 10 27s
• Node.js 12 30s
• Node.js 12 28s

Emmmm, I think it is still necessary to have #3839 then.

[curbengh]

Emmmm, I think it is still necessary to have #3839 then.

#3839 is duplicate of hexojs/hexo-util#124, so #3835 is necessary, otherwise it defeats the purpose of hexojs/hexo-util#119.

[SukkaW]

@curbengh Yeah. So I need to find out what cause the difference between #3839 and hexojs/hexo-util#124.

[curbengh]

My guess is that there is a possibility that [email protected] is still used because it's installed by dependency as sub-dependency.

[SukkaW]

@curbengh Currently, the only difference between #3839 and hexojs/hexo-util#124 is how it handle exclude. #3839 converts exclude into array first, then isExternal() uses exclude as an array directly. While hexojs/hexo-util#124 still converts exclude into array every time isExternalLink() is called.

---

But according to #3839 (comment), it shouldn't cause so much difference:

After 6d9ed7a , it drops from 76s to 72s on Node.js 13 (and Node.js 12 remains 76s).

---

Bingo! I have triggered a rebuild for #3839, and the performance drops to more or less the same with this PR now.

[SukkaW]

Rebased and ready for review. Should be merged after a newer version of hexo-util is released.

[SukkaW]

I think I might add extra changes to this PR.

---

It is possible to only register external_link filter only when enabled in external_link related config, but what should we do to test this?

[curbengh]

Please update thie repo's hexo-util to 1.6.0.

[curbengh]

Need to include 8ecb782 when updating hexo-util to 1.6.0 to pass the test.

[SukkaW]

Should be superseded by #3888