refactor(isExternal): avoid undefined & improve performance #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
reviewed
Nov 9, 2019
lib/is_external_link.js
Outdated
| const host = data.hostname; | ||
| const sitehost = typeof urlObj(config.url) === 'object' ? urlObj(config.url).hostname : config.url; | ||
| const sitehost = parse(config.url).hostname || config.url; | ||
| // Pass a base to new URL |
There was a problem hiding this comment.
I would say the purpose is // Relative url handling.
There was a problem hiding this comment.
Updated to // handle relative url since there is a handle mailto: javascript: vbscript: and so on below.
curbengh
requested changes
Nov 9, 2019
lib/is_external_link.js
Outdated
| const sitehost = typeof urlObj(config.url) === 'object' ? urlObj(config.url).hostname : config.url; | ||
| const sitehost = parse(config.url).hostname || config.url; | ||
| // Pass a base to new URL | ||
| const data = new URL(url, `http://${sitehost}`); | ||
|
|
||
| if (!sitehost || typeof data === 'string') return false; |
There was a problem hiding this comment.
with L15, typeof data is no longer required since it will always be an "object".
curbengh
requested changes
Nov 9, 2019
lib/is_external_link.js
Outdated
| @@ -18,17 +10,19 @@ const urlObj = (str) => { | |||
|
|
|||
| function isExternalLink(url) { | |||
There was a problem hiding this comment.
suggest to rename to path or input to not confuse with new URL().
There was a problem hiding this comment.
input might be a good idea.
Apply suggestions from code review by @curbengh
2 tasks
|
It's fine to use |
curbengh
previously approved these changes
Nov 9, 2019
|
@curbengh So should we should throw a TypeError if |
curbengh
approved these changes
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes #123 with a simpler way. This PR also includes the changes from hexojs/hexo#3839 , which is a poc of performance improvements.