Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(load-balancer): ignore nodes that don't use known provider IDs #780

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukasmetzner
Copy link
Contributor

With this feature the load balancer is more resilient to hybrid clusters as it skips nodes with unkown provider ids.

With this feature the load balancer is more resilient to hybrid clusters as it skips nodes with unkown provider ids.
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (006b0ad) to head (3e98ad9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/hcops/load_balancer.go 0.00% 11 Missing ⚠️
internal/providerid/providerid.go 11.11% 8 Missing ⚠️
hcloud/instances.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   70.29%   69.77%   -0.53%     
==========================================
  Files          31       31              
  Lines        3205     3229      +24     
==========================================
  Hits         2253     2253              
- Misses        779      803      +24     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(load-balancer): ignore nodes that don't use known provider IDs
1 participant