Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no events are emitted as broadcaster has no sink configured #774

Conversation

lukasmetzner
Copy link
Contributor

As there is no sink configured for our broadcaster, no events are emitted.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 70.29%. Comparing base (7960ddc) to head (8af0090).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/cloud.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   70.57%   70.29%   -0.28%     
==========================================
  Files          31       31              
  Lines        3198     3205       +7     
==========================================
- Hits         2257     2253       -4     
- Misses        768      779      +11     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hcloud/cloud.go Outdated Show resolved Hide resolved
@lukasmetzner lukasmetzner force-pushed the 772-fix-no-events-are-emitted-as-broadcaster-has-no-sink-configured branch from 3030575 to 8af0090 Compare October 31, 2024 10:02
@lukasmetzner lukasmetzner merged commit 635c727 into main Oct 31, 2024
10 checks passed
@lukasmetzner lukasmetzner deleted the 772-fix-no-events-are-emitted-as-broadcaster-has-no-sink-configured branch October 31, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: no events are emitted as broadcaster has no sink configured
2 participants