Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(completion): read network zones from API #426

Merged
merged 1 commit into from
Nov 28, 2022
Merged

feat(completion): read network zones from API #426

merged 1 commit into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. feat(completion): read network zones from API 

    We previously hard-coded the available network zones for autocompletion
purposes. This makes it easy to forget to add them, or only update the list
in one location (as you can see, it's currently missing us-east for the
loadbalancer create call).

In this PR we replace the hardcoded list with an api call that retrieves
all available network zones from the API. As there is no dedicated
`GET /v1/network_zones` endpoint, we use the network zone referenced in
the `GET /v1/locations` response.
    @apricote
    apricote committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5db5050 View commit details
    Browse the repository at this point in the history