feat(completion): read network zones from API #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously hard-coded the available network zones for autocompletion purposes. This makes it easy to forget to add them, or only update the list in one location (as you can see, it's currently missing us-east for the loadbalancer create call). In this PR we replace the hardcoded list with an api call that retrieves all available network zones from the API. As there is no dedicated `GET /v1/network_zones` endpoint, we use the network zone referenced in the `GET /v1/locations` response.
LKaemmerling
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously hard-coded the available network zones for autocompletion purposes. This makes it easy to forget to add them, or only update the list in one location (as you can see, it's currently missing us-east for the loadbalancer create call).
In this PR we replace the hardcoded list with an api call that retrieves all available network zones from the API. As there is no dedicated
GET /v1/network_zonesendpoint, we use the network zone referenced in theGET /v1/locationsresponse.