Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bot commit signing #133

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix bot commit signing #133

merged 1 commit into from
Sep 1, 2023

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented Aug 29, 2023 •
edited by edmorley
Loading

The previous configuration worked if commits were done manually with a git commit ... but the peter-evans/create-pull-request action will use the GitHub Actions bot as committer and the user that triggered the workflow as author if committer and author are not given as inputs.

Fixes #132
GUS-W-14041925.

@colincasey
Fix bot commit signing
8323373 
The previous configuration worked if commits were done manually with a `git commit ...` but the [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) action will use the GitHub Actions bot as committer and the user that triggered the workflow as author if  `committer` and `author` are not given as inputs.
@colincasey colincasey added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Aug 29, 2023
@colincasey colincasey self-assigned this Aug 29, 2023
@colincasey colincasey requested a review from a team as a code owner August 29, 2023 18:02
@edmorley edmorley merged commit d95caef into main Sep 1, 2023
@edmorley edmorley deleted the fix_commit_signing branch September 1, 2023 08:21
colincasey added a commit that referenced this pull request Sep 11, 2023
@colincasey
Merge branch 'main' into keep_libcnb_tools_in_sync
fa4cc79 
* main:
  Allow testing of CLI changes from a branch (#134)
  Fix bot commit signing (#133)
  Group minor/patch version Rust Dependabot updates into one PR (#136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees

@colincasey colincasey

Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix commit signing
2 participants
@colincasey @edmorley