Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commit signing #132

Closed
colincasey opened this issue Aug 29, 2023 · 0 comments · Fixed by #133
Closed

Fix commit signing #132

colincasey opened this issue Aug 29, 2023 · 0 comments · Fixed by #133
Assignees
Labels
bug Something isn't working

Comments

@colincasey
Copy link
Contributor

colincasey commented Aug 29, 2023

The commit signing configuration shown below doesn't work as expected with peter-evans/create-pull-request:

- name: Configure git
  run: |
    git config --global user.name ${{ inputs.app_username }}
    git config --global user.email ${{ inputs.app_email }}

Instead, this should be configured using the committer and author inputs on the peter-evans/create-pull-request action. E.g.;

- name: Create Pull Request
  id: pr
  uses: peter-evans/create-pull-request@v5
  with:
    committer: ${{ inputs.app_username }} <${{ inputs.app_email }}>
    author: ${{ inputs.app_username }} <${{ inputs.app_email }}>
    # ...

GUS-W-14041925.

@colincasey colincasey added the bug Something isn't working label Aug 29, 2023
edmorley pushed a commit that referenced this issue Sep 1, 2023
The previous configuration worked if commits were done manually with a `git commit ...` but the [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) action will use the GitHub Actions bot as committer and the user that triggered the workflow as author if  `committer` and `author` are not given as inputs.

Fixes #132
GUS-W-14041925.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant