Move from github.com/mattes/migrate => github.com/golang-migrate/migrate repo

[djui]

Fixes #256.

Also fixes the filename download URL: migrate.linux-amd64.tar.gz not migrate-linux-amd64.tar.gz.

[danp]

Thanks for this!

Looks like some test output checking needs to be updated.

Also, what should folks who still have github.com/mattes/migrate in heroku.additionalTools expect to happen?

[djui]

Looks like some test output checking needs to be updated.

Was not aware of the test cases. Will take care of it.

Also, what should folks who still have github.com/mattes/migrate in heroku.additionalTools expect to happen?

That's a valid question. I am not sure. So far I would assume that no-one uses that feature as it actually does not work. So we might not have to worry about that case. But likely only you know the numbers for that.

[danp]

We do use it internally. Re it not working based on filename, maybe there is confusion between the filename key here (which I think ensureFile eventually works from) and the released filename:

heroku-buildpack-go/files.json

Lines 334 to 337 in 8f0649c

	"migrate-v3.0.0-linux-amd64.tar.gz": {
	"SHA": "13fbabe2db0ee3f79611c8171b0596939a3f384025f62925ed136267681e4fbf",
	"URL": "https://github.com/mattes/migrate/releases/download/v3.0.0/migrate.linux-amd64.tar.gz"
	},

Perhaps the buildpack should support either being in heroku.additionalTools, preferring github.com/golang-migrate/migrate, and printing a warning if only github.com/mattes/migrate is used?

[danp]

Should add too there are tests that specifically verify having github.com/mattes/migrate in heroku.additionalTools works, such as:

heroku-buildpack-go/test/run

Lines 30 to 46 in 8f0649c

	testDepWithMattesMigrate() {
	fixture "dep-mattes-migrate"
	assertDetected
	compile
	assertCaptured "Installing go"
	assertCaptured "Fetching dep"
	assertCaptured "Fetching any unsaved dependencies (dep ensure)"
	assertCaptured "Running: go install -v -tags heroku ."
	assertCaptured "github.com/heroku/fixture"
	assertCaptured "Installing github.com/mattes/migrate"
	assertCaptured "Fetching migrate"
	assertCapturedSuccess
	assertCompiledBinaryExists
	assertCompiledBinaryExists "migrate"
	}

and:

heroku-buildpack-go/test/run

Lines 159 to 176 in 8f0649c

	testGovendorMattesMigrateCLI() {
	fixture "govendor-mattes-migrate"
	assertDetected
	compile
	assertCaptured "Checking vendor/vendor.json file."
	assertCaptured "Installing go"
	assertCaptured "Fetching govendor"
	assertCaptured "Fetching any unsaved dependencies (govendor sync)"
	assertCaptured "Running: go install -v -tags heroku ."
	assertCaptured "Installing github.com/mattes/migrate"
	assertCaptured "Fetching migrate"
	assertCapturedSuccess
	assertCompiledBinaryExists
	assertCompiledBinaryOutputs "fixture" "hello"
	assertCompiledBinaryExists "migrate"
	}

[freeformz]

This won't work as it breaks existing users who could push afterwards and not get mattes migrate as they expected.

[freeformz]

See #264 for how I would like to do it so as to not break existing users and allow them some time to migrate.

[freeformz]

I'm going to close this since I merged #264. @djui Thanks for bringing up this issue. I'm sorry we couldn't use your PR in the end.

[djui]

@freeformz makes sense and thanks for taking over this issue! 🙇