-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate mattes/migrate
to new repo golang-migrate/migrate
#256
Comments
mattes/migrate
to new repo golang-migrate/migrate
Looking a bit closer, I actually believe this feature never worked, as the release binary filename (at least nowadays is So maybe a breaking change (and only supporting the new repo) is tolerable here. |
Looking a bit further into the code, the For example (and for compatibility reasons likely with a different key [metadata.heroku]
additional-tools = ["./scripts/download_migrate.sh"] or [metadata.heroku]
additional-tools = [
[
"curl -s -f -O migrate.tar.gz -L https://github.com/golang-migrate/migrate/releases/download/v3.4.0/migrate.linux-amd64.tar.gz",
"tar xvz migrate.tar.gz",
]
] Anyway, whole different can of worms. |
The
mattes/migrate
repo is archived since 8th May and superseded by golang-migrate/migrate now. Support for this repo instead (or mid-term both side-by-side to not break current app deployments) would be nice to keep up with features and security patches (v3.0.1 vs v.3.4.0).Of course, one can fork the buildpack or use install it as a vendored
go get
dependency, but would be nice to maintain that feature.I might give the PR a try, but seeing how the repo patch is regexp in different tools (
sed
,grep
,jq
,tq
) will likely make supporting both more complex that the benefit it offers.The text was updated successfully, but these errors were encountered: