Switch away from workspace-defined dependencies #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Dependabot and `cargo-edit`'s `cargo upgrade` don't seem to handle dependencies being specified in the Cargo workspace `Cargo.toml` and inherited by individual crates. As such, this switches back to specifying those dependencies explicitly in each crate. Dependabot always updates dependencies across all crates, so they will still stay in sync. Hopefully this change will fix: ``` updater | 2023/11/17 15:48:21 INFO <job_751330580> No update possible for libcnb 0.15.0 ``` Seen in: https://github.com/heroku/buildpacks-jvm/network/updates/751330580 I've left the local shared crate dependencies as workspace-defined, since Dependabot or `cargo-edit` doesn't need to update those, since they are path-only dependencies. Lastly, the lists of dependencies have been sorted alphabetically.
edmorley
added
the
skip changelog
Malax
approved these changes
Nov 17, 2023
|
Agree - though less bad than me having to manually open a libcnb PR every time :-) Dependabot is now working again at least: #615 |
edmorley
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Nov 17, 2023
Both Dependabot and `cargo-edit`'s `cargo upgrade` don't seem to handle dependencies being specified in the Cargo workspace `Cargo.toml` and inherited by individual crates very well. As such, this switches back to specifying those dependencies explicitly in each crate. Dependabot always updates dependencies across all crates, so they will still stay in sync. This will unblock Dependabot being able to open a PR for libcnb 0.16.0. See also: heroku/buildpacks-jvm#614 I've left the local shared crate dependencies as workspace-defined, since Dependabot or `cargo-edit` doesn't need to update those, since they are path-only dependencies. Lastly, the lists of dependencies have been sorted alphabetically. GUS-W-14513796.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Dependabot and
cargo-edit'scargo upgradedon't seem to handle dependencies being specified in the Cargo workspaceCargo.tomland inherited by individual crates very well.As such, this switches back to specifying those dependencies explicitly in each crate. Dependabot always updates dependencies across all crates, so they will still stay in sync.
Hopefully this change will fix:
Seen in:
https://github.com/heroku/buildpacks-jvm/network/updates/751330580
I've left the local shared crate dependencies as workspace-defined, since Dependabot or
cargo-editdoesn't need to update those, since they are path-only dependencies.Lastly, the lists of dependencies have been sorted alphabetically.
GUS-W-14513805.