-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an inventory file for OpenJDK distribution files #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
commented
May 21, 2024
edmorley
approved these changes
May 21, 2024
This was referenced May 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inventory File
This PR uses https://github.com/malax/inventory for handling inventory files in a generic manner. That crate still needs some polish, but is usable in the current state. I'd like to get this PR merged before we finalize https://github.com/malax/inventory. The code in that crate is based on the work @runesoerensen did for the Go buildpack, so it's already in production regardless of this PR.
Inventory File Contents (41% of lines added in this PR)
The contents of the inventory file uses a new S3 bucket instead of the existing one. We plan to migrate all JVM buildpacks (CNB and classic) to this bucket eventually.
OpenJDK version parsing (27% of lines added in this PR)
OpenJDK version parsing for both "legacy" version strings used by OpenJDK
8
and JEP 322 version strings (used by OpenJDK >=10
). Support for JEP 223 strings is not implemented since all OpenJDK versions that use that versioning format are already EOL.I tried implementing the parsing using only
std
, but the complexity of the spec as well as supporting two slightly overlapping specs made me usingnom
for parsing.Deliberately Omitted
Fixes #499