Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symbol Names to match Godot, Fix Request Call Args #186

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

beelol
Copy link
Contributor

@beelol beelol commented Sep 15, 2023

Change HTTPRequest -> HttpRequest to match Godot's new naming.

Change .Request call to contain 4 args to match new Godot signature for HttpRequest.Request

Change HTTPRequest -> HttpRequest to match Godot's new naming.

Change .Request call to contain 4 args to match new Godot signature for HttpRequest.Request
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023

CLA assistant check
All committers have signed the CLA.

@novabyte novabyte requested a review from dsnopek September 16, 2023 14:07
@ericburns
Copy link

@novabyte any update on pushing this change through? FWIW, I was stopping by to submit an identical PR. I'm working in Godot 4.2.1.stable.mono.official and this fixed it for me.

@lugehorsam
Copy link

Hey @ericburns and @beelol could either of you point us to where the naming has been changed? I still see it as HTTPRequest here -- https://docs.godotengine.org/en/stable/classes/class_httprequest.html

If it is now HttpRequest, was it type-aliased toHTTPRequest for backwards compatibility? In other words, how would this code still be working?

@ericburns
Copy link

ericburns commented Mar 13, 2024

Copy link

@lugehorsam lugehorsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks guys 🙏

@lugehorsam lugehorsam merged commit e76e4dc into heroiclabs:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants