-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PascalCase naming inconsistencies with C# #28748
Comments
Probably not going to be done for 3.2, and it would break C# compatibility, I suggest bumping to 4.0. |
Guess we can add a list of custom casing for words like these. |
I'm not keen of going all upper case for acronyms and some other words, like the following: It can result in hard to read names:
I tend to agree with what is said here: https://www.approxion.com/capital-offenses-how-to-handle-abbreviations-in-camelcase/ The convention in .NET seems to be capitalizing only the first letter (e.g.: Personally, I'd prefer it without the two-letter exception (I don't have a problem with The only downside of following this convention is that currently we keep the original casing of Godot class names (e.g.: |
100% agree with @neikeq - also bear in mind that https://en.wikipedia.org/wiki/Filename is a real word, having "file name" (and file_name, FileName, fileName etc.) was always a bit strange for me, since we have a single common word describing exactly what we have, and not some abstract "name" of a file. |
Godot version: 3.1.1 and master
Issue description: There are a lot of cases in the Mono module where the generated C# methods and properties are not using PascalCase properly. This is understandably due to this information not being present when these names are written out in snake_case. See also: #32734
In some cases, this also effects the editor, as the displayed name could be improved:
Here's my attempt to document what could be fixed:
Node:
Callv
->CallV
Editor__displayFolded
-> Don't expose this?Rpc
etc ->RPC
etcRset
etc ->RSet
etc?Node2D:
GetWorld2d
->GetWorld2D
Label:
Valign
->VAlign
Autowrap
->AutoWrap
Particles and Particles2D:
FixedFps
->FixedFPS
PathFollow:
Xy
->XY
andXyz
->XYZ
PathFollow2D:
Lookahead
->LookAhead
Polygon2D:
Antialiased
->AntiAliased
Uv
->UV
RichTextLabel:
Bbcode
etc ->BBCode
etcSprite:
Hframes
->HFrames
and get/setVframes
->VFrames
and get/setTextEdit:
Readonly
->ReadOnly
TileMap:
CellClipUv
->CellClipUV
GetCellv
etc ->GetCellV
or justGetCell
(overloaded method)TouchScreenButton:
Bitmask
->BitMask
TouchscreenOnly
->TouchScreenOnly
Tree:
AllowRmbSelect
->AllowRMBSelect
Various players:
Autoplay
->AutoPlay
VideoPlayer:
BufferingMsec
->BufferingMSec
VisibilityNotifier:
Aabb
->AABB
Misc:
Aot
->AOT
Rid
->RID
in many places.The text was updated successfully, but these errors were encountered: