Implement GDB server using gdbstub #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
gdbstub
branch
3 times, most recently
from
1ad2a5e
to
42776ca
Compare
This was referenced Aug 30, 2021
mkroening
force-pushed
the
gdbstub
branch
2 times, most recently
from
8015787
to
ce67ed3
Compare
mkroening
force-pushed
the
gdbstub
branch
2 times, most recently
from
4e6fb06
to
ff25173
Compare
mkroening
force-pushed
the
gdbstub
branch
2 times, most recently
from
cbf38f0
to
2ad4a24
Compare
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
===========================================
- Coverage 30.85% 14.91% -15.95%
===========================================
Files 16 17 +1
Lines 4012 2635 -1377
===========================================
- Hits 1238 393 -845
+ Misses 2774 2242 -532
Continue to review full report at Codecov.
|
bors bot
added a commit
that referenced
this pull request
Sep 7, 2021
186: Use concrete vCPU structs instead of trait objects r=jounathaen a=mkroening In #164, I implement additional traits for `UhyveCPU` on linux, but not on macos. To be able to use the trait impls, this makes the vCPU structs concrete instead of using trait objects. Co-authored-by: Martin Kröning <[email protected]>
mkroening
force-pushed
the
gdbstub
branch
3 times, most recently
from
b579573
to
59e681b
Compare
Merged
mkroening
force-pushed
the
gdbstub
branch
2 times, most recently
from
dd73ba8
to
2980413
Compare
bors bot
added a commit
that referenced
this pull request
Sep 7, 2021
188: Expose section offsets r=stlankes a=mkroening Access to section offsets is necessary for debugging (#164). Co-authored-by: Martin Kröning <[email protected]>
mkroening
force-pushed
the
gdbstub
branch
2 times, most recently
from
5471167
to
dfd35fb
Compare
mkroening
force-pushed
the
gdbstub
branch
2 times, most recently
from
6b7e8b3
to
7e6b5cb
Compare
|
This is ready for review now. 🎉 I'll tackle integration tests separately. Unit tests don't make much sense here, I think. |
mkroening
changed the title
mkroening
force-pushed
the
gdbstub
branch
2 times, most recently
from
3baec29
to
87c7064
Compare
mkroening
commented
Sep 17, 2021
mkroening
commented
Sep 17, 2021
|
bors r=jounathaen |
bors bot
added a commit
that referenced
this pull request
Sep 17, 2021
204: GDB: Correctly report stop reasons for watchpoints r=mkroening a=mkroening This fixes watchpoints in GDB (an oversight from #164). Found while working on integration tests, `@jounathaen.` ;) bors r+ Co-authored-by: Martin Kröning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122. Closes #50.
This reimplements the GDB server using gdbstub.