This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Add option to set MongoDB URL string in a secret #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the conditional logic with "mongodb.url" helper definition. Also remove HTTP_PROXY AND HTTPS_PROXY ENV vars outside the mongodb.enabled conditional wrapper - I believe that was an unintentional result of two PRs merging cleanly in close proximity: - helm#547 - helm#554 Signed-off-by: Scott Rigby <[email protected]>
Signed-off-by: Scott Rigby <[email protected]>
…implify Signed-off-by: Scott Rigby <[email protected]>
prydonius
reviewed
Nov 26, 2018
| {{- else if $global.Values.global.mongoUrl }} | ||
| - --mongo-url={{ $global.Values.global.mongoUrl }} | ||
| {{- else if $global.Values.global.mongoUrlSecret }} | ||
| - --mongo-url={{ "$MONGO_URL" }} |
There was a problem hiding this comment.
Are the {{ }} needed here? I think this could just be
Suggested change
| - --mongo-url={{ "$MONGO_URL" }} | |
| - --mongo-url="$MONGO_URL" |
| - name: MONGO_PASSWORD | ||
| valueFrom: | ||
| secretKeyRef: | ||
| key: mongodb-root-password | ||
| name: {{ template "mongodb.fullname" $global }} | ||
| {{- end }} | ||
| {{- if $global.Values.global.mongoUrlSecret }} |
There was a problem hiding this comment.
this could be elseif I guess, though does not really matter much...
| # You may set the connection URL in one of two ways: | ||
| # - mongoUrl: store the connection string directly in Helm values | ||
| # - mongoUrlSecret: name of the secret where the connection string is stored, | ||
| # where the key is "mongo-url-secret". See NOTES.txt. | ||
| global: |
There was a problem hiding this comment.
What do you think about moving this configuration to externalDatabase? e.g. https://github.com/helm/charts/blob/master/stable/wordpress/values.yaml#L78. Then in the future we are one step closer to splitting up the options in host, user, password, etc. It would make this a breaking change, but I doubt anyone is using this setting yet so the risk should be very low.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On one hand this could be further simplified by removing the string option, and only allowing the secret option. But that would require a MAJOR version bump (removing an existing option), whereas this only requires MINOR. @prydonius What do you think?