This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
add http proxy variables for jobs #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cvila84 nice, thanks! We should add those values to the values.yaml file as well, commented out. Also, please bump the chart minor version! You also need to sign-off on your commits, see https://github.com/helm/monocular/pull/554/checks |
Signed-off-by: Christophe VILA <[email protected]> add http proxy variables for jobs
|
@prydonius done ! |
scottrigby
added a commit
to scottrigby/monocular
that referenced
this pull request
Nov 22, 2018
Simplify the conditional logic with "mongodb.url" helper definition. Also remove HTTP_PROXY AND HTTPS_PROXY ENV vars outside the mongodb.enabled conditional wrapper - I believe that was an unintentional result of two PRs merging cleanly in close proximity: - helm#547 - helm#554 Signed-off-by: Scott Rigby <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposal to fix #542
Proxy now can be set in values.yaml, and will be passed as standard HTTP_PROXY and HTTPS_PROXY environment variables to chart-repo/sync which supports it as it is using standard GoLang http library