This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/datadog] Update README #23334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
Contribution Allowed
|
Not sure it makes sense to bump the Chart version for this? |
|
The GitLab CI enforces the Chart version bump… even for README ! 🤦 |
|
@xlucas The policy on this repository is that any time there is a change the chart version is bumped. Even for readme file changes. This is enforced with automation so it cannot be merged until the version is incremented. |
Signed-off-by: Xavier Lucas <[email protected]>
helm-bot
removed
the
Contribution Allowed
Signed-off-by: Xavier Lucas <[email protected]>
helm-bot
added
the
Contribution Allowed
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: L3n41c, xlucas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
li-adrienloiseau
pushed a commit
to li-adrienloiseau/charts
that referenced
this pull request
Jul 29, 2020
* Correct default values Signed-off-by: Xavier Lucas <[email protected]> * Bump version Signed-off-by: Xavier Lucas <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
* Correct default values Signed-off-by: Xavier Lucas <[email protected]> * Bump version Signed-off-by: Xavier Lucas <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
What this PR does / why we need it:
Update the README with the right default values for resource constraints.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])