Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/datadog] Resources are not enabled as documented #22661

Closed
InAnimaTe opened this issue Jun 4, 2020 · 3 comments · Fixed by #23334
Closed

[stable/datadog] Resources are not enabled as documented #22661

InAnimaTe opened this issue Jun 4, 2020 · 3 comments · Fixed by #23334
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@InAnimaTe
Copy link

InAnimaTe commented Jun 4, 2020

Describe the bug
As per https://github.com/helm/charts/blob/master/stable/datadog/values.yaml#L467, Resources for each agent container are commented out instead of being enabled as eluded to in the docs (under configuration options)

Which chart:
2.3.8 of the datadog chart

@xlucas @clamoriniere Please halp! Thanks!

PS: Any insight/links on how these values were derived and how accurate they are would be in larger clusters would be much appreciated!

@stale
Copy link

stale bot commented Jul 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this as completed Jul 18, 2020
@xlucas
Copy link
Collaborator

xlucas commented Jul 22, 2020

Sorry for the late reply, yeah there's an issue indeed default resource limits were removed by #13138 (and that makes sense) but the README wasn't updated accordingly 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants