Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/druid] fix invalid default values.yaml configuration that crashes JVM #23121

Closed
wants to merge 2 commits into from
Closed

[incubator/druid] fix invalid default values.yaml configuration that crashes JVM #23121

wants to merge 2 commits into from

Conversation

elad-yosifon
Copy link

What this PR does / why we need it:

default values crash JVM in druid middle manager peons

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @elad-yosifon. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maver1ck
Copy link
Collaborator

maver1ck commented Jul 9, 2020

@elad-yosifon
Please bump chart version and signoff all commits

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2020
@elad-yosifon elad-yosifon mentioned this pull request Jul 9, 2020
Closed
4 tasks
@AWaterColorPen
Copy link
Collaborator

@elad-yosifon please rebase #23115. The latest chart version is 0.2.8 now, we have to bump chart version again.

@elad-yosifon
[incubator/druid] fix invalid default values.yaml configuration that …
6ee23a0 
…crashes JVM + Fix local storage mounting path and permissions (helm#23069)

Signed-off-by: Elad Yosifon <[email protected]>
@maver1ck
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2020
@AWaterColorPen
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AWaterColorPen, elad-yosifon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@elad-yosifon
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@elad-yosifon: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-charts-e2e 5515ca0 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AWaterColorPen AWaterColorPen mentioned this pull request Aug 18, 2020
Merged
4 tasks
@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2020
@stale
Copy link

stale bot commented Sep 12, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maver1ck maver1ck maver1ck left review comments

@AWaterColorPen AWaterColorPen AWaterColorPen left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elad-yosifon @k8s-ci-robot @maver1ck @AWaterColorPen @helm-bot