-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/druid] Fix local storage mounting path and permissions #23069
Conversation
* For Historical and MiddleManager nodes, when using local filesystems to store segments (historical) and indecies (middle-manager), current configuration does not actually use mounted pvc. * This fix instructs Historical and MiddleManager nodes to use PV created for Druid and mount volumes to `/opt/druid/var/druid`, which is the default path to store stateful files. * This fix also adds `securityContext` to Historical and MiddleManager stateful sets with `fsGroup: 1000` to fix permission issues.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhuheec The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @zhuheec. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@zhuheec please update the chart version at BTW Could you tell the story about deleting druid_indexer_logs_directory. |
@@ -26,7 +26,6 @@ configVars: | |||
druid_metadata_storage_connector_password: druid | |||
druid_storage_type: local | |||
druid_indexer_logs_type: file | |||
druid_indexer_logs_directory: /opt/data/indexing-logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably a fallback to defaults
@maver1ck @AWaterColorPen this is a "show stopper" - historical service is not working. |
@elad-yosifon It is a good fix, but blocked. 😭 If you are anxious, there is a work around:
BTW, @zhuheec for update |
…crashes JVM + Fix local storage mounting path and permissions (helm#23069) Signed-off-by: Elad Yosifon <[email protected]>
@AWaterColorPen #23121 -> I added those changes there... |
…crashes JVM + Fix local storage mounting path and permissions (helm#23069) Signed-off-by: Elad Yosifon <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
to store segments (historical) and indecies (middle-manager), current
configuration does not actually use mounted pvc.
created for Druid and mount volumes to
/opt/druid/var/druid
, whichis the default path to store stateful files.
securityContext
to Historical and MiddleManagerstateful sets with
fsGroup: 1000
to fix permission issues.Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)