Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/druid] Fix local storage mounting path and permissions #23069

Closed
wants to merge 1 commit into from
Closed

[incubator/druid] Fix local storage mounting path and permissions #23069

wants to merge 1 commit into from

Conversation

stedrew
Copy link

@stedrew stedrew commented Jul 3, 2020

  • For Historical and MiddleManager nodes, when using local filesystems
    to store segments (historical) and indecies (middle-manager), current
    configuration does not actually use mounted pvc.
  • This fix instructs Historical and MiddleManager nodes to use PV
    created for Druid and mount volumes to /opt/druid/var/druid, which
    is the default path to store stateful files.
  • This fix also adds securityContext to Historical and MiddleManager
    stateful sets with fsGroup: 1000 to fix permission issues.

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

* For Historical and MiddleManager nodes, when using local filesystems
to store segments (historical) and indecies (middle-manager), current
configuration does not actually use mounted pvc.
* This fix instructs Historical and MiddleManager nodes to use PV
created for Druid and mount volumes to `/opt/druid/var/druid`, which
is the default path to store stateful files.
* This fix also adds `securityContext` to Historical and MiddleManager
stateful sets with `fsGroup: 1000` to fix permission issues.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhuheec
To complete the pull request process, please assign maver1ck
You can assign the PR to them by writing /assign @maver1ck in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @zhuheec. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2020
@AWaterColorPen
Copy link
Collaborator

AWaterColorPen commented Jul 4, 2020

@zhuheec please update the chart version at Chart.yaml. And please sign off all your commits.

BTW Could you tell the story about deleting druid_indexer_logs_directory.

@@ -26,7 +26,6 @@ configVars:
druid_metadata_storage_connector_password: druid
druid_storage_type: local
druid_indexer_logs_type: file
druid_indexer_logs_directory: /opt/data/indexing-logs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a fallback to defaults

@elad-yosifon
Copy link

@maver1ck @AWaterColorPen this is a "show stopper" - historical service is not working.
is there any way to promoted this PR?
if this is blocked because of sign-offs etc - I can create a duplicate PR with everything

@AWaterColorPen
Copy link
Collaborator

@elad-yosifon It is a good fix, but blocked. 😭

If you are anxious, there is a work around:

  1. add druid_segmentCache_locations: '[{"path":"/var/druid/segment-cache","maxSize":300000000000}]' to historical.config
  2. change the docker USER from druid to root (It is too hack😭)

BTW, @zhuheec for update

elad-yosifon added a commit to elad-yosifon/charts that referenced this pull request Jul 9, 2020
…crashes JVM + Fix local storage mounting path and permissions (helm#23069)

Signed-off-by: Elad Yosifon <[email protected]>
@elad-yosifon
Copy link

@AWaterColorPen #23121 -> I added those changes there...

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants