Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Fix minor inconsistencies in time series naming in CoreDNS dashboard #18036

Merged
merged 2 commits into from
Oct 17, 2019
Merged

[stable/prometheus-operator] Fix minor inconsistencies in time series naming in CoreDNS dashboard #18036

merged 2 commits into from
Oct 17, 2019

Conversation

tongpu
Copy link
Contributor

@tongpu tongpu commented Oct 16, 2019

What this PR does / why we need it:

This PR fixes inconsistencies in the naming of time series labels in the CoreDNS dashboard.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tongpu. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tongpu
Copy link
Contributor Author

tongpu commented Oct 16, 2019

@vsliouniaev Just a few small fixes in the dashboard for CoreDNS that I ran into when checking the panels. As this is the only dashboard maintained in this repo I believe there's no upstream where these changes should be performed.

@vsliouniaev
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2019
@tongpu
Copy link
Contributor Author

tongpu commented Oct 16, 2019

/retest

@tongpu tongpu force-pushed the bug_typo_k8s-coredns branch from a9ab8ed to 8fc7e9c Compare October 17, 2019 12:29
@vsliouniaev
Copy link
Collaborator

/test all

Lukas Grossar added 2 commits October 17, 2019 15:17
[stable/prometheus-operator] Add percent sign to k8s-coredns dashboard
47a65c9 
Multiple pannels where missing a percent sign to clearly show to the
user that the graphs shown are for different percentiles.

Signed-off-by: Lukas Grossar <[email protected]>
[stable/prometheus-operator] Fix typo in query for k8s-coredns dashboard
315d02c 
Fixed a typo in one of the queries for the "Responses (size, udp)" where
the timeseries for the 90th percentile was not showing up because of a
missing tiled in the query.

Signed-off-by: Lukas Grossar <[email protected]>
@tongpu tongpu force-pushed the bug_typo_k8s-coredns branch from 8fc7e9c to 315d02c Compare October 17, 2019 13:18
@vsliouniaev
Copy link
Collaborator

I think this dashboard was pulled from the grafana dashboard repository. That one might have a more up-to-date version of this that might be helpful

@vsliouniaev
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tongpu, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit f8987c7 into helm:master Oct 17, 2019
@tongpu
Copy link
Contributor Author

tongpu commented Oct 17, 2019

I think this dashboard was pulled from the grafana dashboard repository. That one might have a more up-to-date version of this that might be helpful

The two dashboards that I just checked in the Grafana dashboard repository both contain the typos that I just fixed, so this is the most actively developed one at the moment. :D

@tongpu tongpu deleted the bug_typo_k8s-coredns branch October 17, 2019 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gianrubio gianrubio Awaiting requested review from gianrubio

@vsliouniaev vsliouniaev Awaiting requested review from vsliouniaev

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tongpu @k8s-ci-robot @vsliouniaev @helm-bot