Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Commit

Permalink
[stable/prometheus-operator] Fix minor inconsistencies in time series…
Browse files Browse the repository at this point in the history 
… naming in CoreDNS dashboard (#18036)

* [stable/prometheus-operator] Add percent sign to k8s-coredns dashboard

Multiple pannels where missing a percent sign to clearly show to the
user that the graphs shown are for different percentiles.

Signed-off-by: Lukas Grossar <[email protected]>

* [stable/prometheus-operator] Fix typo in query for k8s-coredns dashboard

Fixed a typo in one of the queries for the "Responses (size, udp)" where
the timeseries for the 90th percentile was not showing up because of a
missing tiled in the query.

Signed-off-by: Lukas Grossar <[email protected]>
  • Loading branch information
@k8s-ci-robot
Lukas Grossar authored and k8s-ci-robot committed Oct 17, 2019
1 parent 1508a8b commit f8987c7
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 29 deletions.
2 changes: 1 addition & 1 deletion stable/prometheus-operator/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ name: prometheus-operator
sources:
- https://github.com/coreos/prometheus-operator
- https://coreos.com/operators/prometheus
version: 6.19.0
version: 6.19.1
appVersion: 0.32.0
home: https://github.com/coreos/prometheus-operator
keywords:
Expand Down
28 changes: 14 additions & 14 deletions stable/prometheus-operator/templates/grafana/dashboards-1.14/k8s-coredns.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,15 +458,15 @@ data:
"renderer": "flot",
"seriesOverrides": [
{
"alias": "tcp:90",
"alias": "tcp:90%",
"yaxis": 2
},
{
"alias": "tcp:99 ",
"alias": "tcp:99%",
"yaxis": 2
},
{
"alias": "tcp:50",
"alias": "tcp:50%",
"yaxis": 2
}
],
Expand All @@ -477,21 +477,21 @@ data:
{
"expr": "histogram_quantile(0.99, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:99 ",
"legendFormat": "{{`{{proto}}`}}:99%",
"refId": "A",
"step": 60
},
{
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:90",
"legendFormat": "{{`{{proto}}`}}:90%",
"refId": "B",
"step": 60
},
{
"expr": "histogram_quantile(0.50, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:50",
"legendFormat": "{{`{{proto}}`}}:50%",
"refId": "C",
"step": 60
}
Expand Down Expand Up @@ -570,15 +570,15 @@ data:
"renderer": "flot",
"seriesOverrides": [
{
"alias": "tcp:90",
"alias": "tcp:90%",
"yaxis": 1
},
{
"alias": "tcp:99 ",
"alias": "tcp:99%",
"yaxis": 1
},
{
"alias": "tcp:50",
"alias": "tcp:50%",
"yaxis": 1
}
],
Expand All @@ -589,29 +589,29 @@ data:
{
"expr": "histogram_quantile(0.99, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"tcp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:99 ",
"legendFormat": "{{`{{proto}}`}}:99%",
"refId": "A",
"step": 60
},
{
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"tcp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:90",
"legendFormat": "{{`{{proto}}`}}:90%",
"refId": "B",
"step": 60
},
{
"expr": "histogram_quantile(0.50, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"tcp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:50",
"legendFormat": "{{`{{proto}}`}}:50%",
"refId": "C",
"step": 60
}
],
"thresholds": [],
"timeFrom": null,
"timeShift": null,
"title": "Requests (size,tcp)",
"title": "Requests (size, tcp)",
"tooltip": {
"shared": true,
"sort": 0,
Expand Down Expand Up @@ -897,7 +897,7 @@ data:
"step": 40
},
{
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_response_size_bytes_bucket{instance=\"$instance\",proto=\"udp\"}[5m])) by (le,proto)) ",
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_response_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto)) ",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:90%",
"refId": "B",
Expand Down
28 changes: 14 additions & 14 deletions stable/prometheus-operator/templates/grafana/dashboards/k8s-coredns.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,15 +458,15 @@ data:
"renderer": "flot",
"seriesOverrides": [
{
"alias": "tcp:90",
"alias": "tcp:90%",
"yaxis": 2
},
{
"alias": "tcp:99 ",
"alias": "tcp:99%",
"yaxis": 2
},
{
"alias": "tcp:50",
"alias": "tcp:50%",
"yaxis": 2
}
],
Expand All @@ -477,21 +477,21 @@ data:
{
"expr": "histogram_quantile(0.99, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:99 ",
"legendFormat": "{{`{{proto}}`}}:99%",
"refId": "A",
"step": 60
},
{
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:90",
"legendFormat": "{{`{{proto}}`}}:90%",
"refId": "B",
"step": 60
},
{
"expr": "histogram_quantile(0.50, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:50",
"legendFormat": "{{`{{proto}}`}}:50%",
"refId": "C",
"step": 60
}
Expand Down Expand Up @@ -570,15 +570,15 @@ data:
"renderer": "flot",
"seriesOverrides": [
{
"alias": "tcp:90",
"alias": "tcp:90%",
"yaxis": 1
},
{
"alias": "tcp:99 ",
"alias": "tcp:99%",
"yaxis": 1
},
{
"alias": "tcp:50",
"alias": "tcp:50%",
"yaxis": 1
}
],
Expand All @@ -589,29 +589,29 @@ data:
{
"expr": "histogram_quantile(0.99, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"tcp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:99 ",
"legendFormat": "{{`{{proto}}`}}:99%",
"refId": "A",
"step": 60
},
{
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"tcp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:90",
"legendFormat": "{{`{{proto}}`}}:90%",
"refId": "B",
"step": 60
},
{
"expr": "histogram_quantile(0.50, sum(rate(coredns_dns_request_size_bytes_bucket{instance=~\"$instance\",proto=\"tcp\"}[5m])) by (le,proto))",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:50",
"legendFormat": "{{`{{proto}}`}}:50%",
"refId": "C",
"step": 60
}
],
"thresholds": [],
"timeFrom": null,
"timeShift": null,
"title": "Requests (size,tcp)",
"title": "Requests (size, tcp)",
"tooltip": {
"shared": true,
"sort": 0,
Expand Down Expand Up @@ -897,7 +897,7 @@ data:
"step": 40
},
{
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_response_size_bytes_bucket{instance=\"$instance\",proto=\"udp\"}[5m])) by (le,proto)) ",
"expr": "histogram_quantile(0.90, sum(rate(coredns_dns_response_size_bytes_bucket{instance=~\"$instance\",proto=\"udp\"}[5m])) by (le,proto)) ",
"intervalFactor": 2,
"legendFormat": "{{`{{proto}}`}}:90%",
"refId": "B",
Expand Down

0 comments on commit f8987c7

Please sign in to comment.