Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add empty prompt input to history #3259

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Don't add empty prompt input to history #3259

merged 1 commit into from
Jul 30, 2022

Conversation

A-Walrus
Copy link
Contributor

Resolves #3246

EricCrosson
EricCrosson approved these changes Jul 30, 2022
View reviewed changes
Copy link
Contributor

@EricCrosson EricCrosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it, @A-Walrus ! Great work

I compiled this PR on my machine and can confirm it fixes #3246 🚀

the-mikedavis
the-mikedavis approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@the-mikedavis the-mikedavis merged commit 5ca98ed into helix-editor:master Jul 30, 2022
@A-Walrus A-Walrus deleted the prompt_empty branch August 1, 2022 07:39
GreasySlug pushed a commit to GreasySlug/helix that referenced this pull request Aug 2, 2022
@A-Walrus @GreasySlug
Don't add empty prompt input to history (helix-editor#3259)
3889cd8
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@A-Walrus @thomasskk
Don't add empty prompt input to history (helix-editor#3259)
dcd08f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@EricCrosson EricCrosson EricCrosson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipe only preloads your last command once
3 participants
@A-Walrus @EricCrosson @the-mikedavis