Pipe only preloads your last command once

[EricCrosson]

Summary

What I did

1. open hx
2. press | and type a command, say fmt -72
3. press | again (this preloads as a default command, the last command I ran (fmt -72)). Hit enter
4. press | again

What I Expected to Happen

The pipe prompt would again preload as a default command the last command I ran, which was the preloaded fmt -72

What Actually Happens

The pipe prompt has no preloaded text (possibly because I didn't type anything before I hit enter last time!)

Reproduction Steps

https://asciinema.org/a/ZcpjTOOH3p1v9TEgtzPnu2dSe

Helix log

n/a

Platform

Linux (Ubuntu 22)

Terminal Emulator

kitty

Helix Version

26501af

[the-mikedavis]

It looks like this happens for all prompts, for example with search as well.

helix/helix-term/src/ui/prompt.rs

Lines 528 to 547 in a8b123f

	// handle executing with last command in history if nothing entered
	let input: Cow<str> = if self.line.is_empty() {
	// latest value in the register list
	self.history_register
	.and_then(|reg| cx.editor.registers.last(reg).cloned())
	.map(|entry| entry.into())
	.unwrap_or_else(|| Cow::from(""))
	} else {
	self.line.as_str().into()
	};
	(self.callback_fn)(cx, &input, PromptEvent::Validate);
	if let Some(register) = self.history_register {
	// store in history
	let register = cx.editor.registers.get_mut(register);
	register.push(self.line.clone());
	}
	return close_fn;
	}

We should probably check that self.line is not empty before pushing it to the history register.