Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align backup system to Neovim's system #11374

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Align backup system to Neovim's system #11374

wants to merge 7 commits into from

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Jul 30, 2024 •
edited
Loading

Resolves #12074 #11362 #11988

kirawi
kirawi commented Jul 30, 2024
View reviewed changes
helix-stdx/src/faccess.rs Outdated Show resolved Hide resolved
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jul 30, 2024
@kirawi kirawi force-pushed the open branch 4 times, most recently from 0a9d853 to c80b4d7 Compare July 31, 2024 01:25
@kirawi
Copy link
Member Author

kirawi commented Jul 31, 2024

Before this can be merged, I realize I need to also call chown for the unix impl.

@archseer archseer added this to the next milestone Aug 9, 2024
@kirawi kirawi mentioned this pull request Nov 10, 2024
Open
@kirawi
Copy link
Member Author

kirawi commented Nov 16, 2024

I'll refactor this pr per #12074

@kirawi kirawi changed the title Create temporary files with the same permissions as the original file Align backup system to Neovim's system Nov 17, 2024
@kirawi

This comment was marked as off-topic.

Sign in to view
@kirawi kirawi added the C-bug Category: This is a bug label Nov 17, 2024
@kirawi
Copy link
Member Author

kirawi commented Nov 18, 2024 •
edited
Loading

Should be good to review now. I'll add documentation if the changes look good. But to summarize:

backup.kind:
- None: never use a backup
- Copy: always use a copy backup
- Auto: use a copy backup if a rename is not safe/possible

backup.directories:
- Equivalent of Neovim's bdir

backup.extension:
- The extension with which backups end in

@kirawi kirawi added the S-waiting-on-review Status: Awaiting review from a maintainer. label Nov 18, 2024
@kirawi kirawi added the E-testing-wanted Call for participation: Experimental features suitable for testing label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-testing-wanted Call for participation: Experimental features suitable for testing S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Align backup system to Neovim's
2 participants
@kirawi @archseer