Writing changes file ownership

[kirawi]

Summary

Writing a file may change the file's ownership when writing.

Reproduction Steps

$ touch abc
$ ls -la abc
-rw-r--r-- 1 m00n m00n 0 Oct 28 23:03 abc
$ sudo helix abc
( Write the file with any content )
$ ls -la
-rw-r--r-- 1 root m00n 4 Oct 28 23:03 abc

Helix log

No response

Platform

All

Terminal Emulator

N/a

Installation Method

release

Helix Version

helix 24.7

[poliorcetics]

I think the issue is

helix/helix-view/src/document.rs

Line 973 in b53dafe

let mut dst = tokio::fs::File::create(&write_path).await?;

, where the file is created with the access rights, owner and group of the running helix process, not that of the target file

[kirawi]

I don't think so. I believe it would open with the same file permissions if it already exists, and for backup files we already copy metadata on

helix/helix-view/src/document.rs

Lines 1008 to 1014 in b53dafe

	// copy metadata and delete backup
	let _ = tokio::task::spawn_blocking(move || {
	let _ = copy_metadata(&backup, &write_path)
	.map_err(|e| log::error!("Failed to copy metadata on write: {e}"));
	let _ = std::fs::remove_file(backup)
	.map_err(|e| log::error!("Failed to remove backup file on write: {e}"));
	})

[kirawi]

Actually you might have been right. This seems to be fixed by #11374