Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(the description is ported with modifications from the 3.x examples removal) PR)
Example removal. Helidon 2 examples now live in the helidon-examples repository
This PR:
examples
profile to include a module calledhelidon-examples
(instead ofexamples
)build-examples
script that clones thehelidon-examples
repository into thehelidon-examples
directory (if it doesn't already exist) and builds the examples.helidon-examples
to .gitignoreThe last three items establish a pattern that can be used by developers to more easily work on changes to examples and core helidon concurrently.
Developing Examples
To make it a bit easier working in two different repositories (
helidon
andhelidon-examples
) you can use this workflow:etc/scripts/build-examples.sh
. This will clone the examples repository'sdev-2.x
branch intohelidon-examples
and build itexamples
profile.If you need to coordinate a (possibly breaking) change in the main
helidon
repo and inhelidon-examples
helidon
might fail the examples validation. But it will not block the PR.helidon-examples
might fail validation. If so it will block the PR.helidon
helidon-examples
PR which should now pass. Then merge.