-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x example removal #8437
Merged
barchetta
merged 9 commits into
helidon-io:helidon-3.x
from
barchetta:3.x-example-removal
Feb 29, 2024
Merged
3.x example removal #8437
barchetta
merged 9 commits into
helidon-io:helidon-3.x
from
barchetta:3.x-example-removal
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Feb 28, 2024
barchetta
force-pushed
the
3.x-example-removal
branch
from
February 29, 2024 00:21
afff55f
to
7007954
Compare
senivam
approved these changes
Feb 29, 2024
romain-grecourt
approved these changes
Feb 29, 2024
This was referenced Mar 1, 2024
Merged
This was referenced Jul 24, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example removal. Helidon 3 examples now live in the helidon-examples repository
This PR:
examples
profile to include a module calledhelidon-examples
(instead ofexamples
)build-examples
script that clones thehelidon-examples
repository into thehelidon-examples
directory (if it doesn't already exist) and builds the examples.helidon-examples
to .gitignoreThe last three items establishes a pattern that can be used by developers to more easily work on changes to examples and core helidon concurrently.
Documentation
Any documentation that references examples will need to have those links updated.
Developing Examples
To make it a bit easier working in two different repositories (
helidon
andhelidon-examples
) you can use this workflow:etc/scripts/build-examples.sh
. This will clone the examples repository'sdev-3.x
branch intohelidon-examples
and build itexamples
profile.If you need to coordinate a (possibly breaking) change in the main
helidon
repo and inhelidon-examples
helidon
might fail the examples validation. But it will not block the PR.helidon-examples
might fail validation. If so it will block the PR.helidon
helidon-examples
PR which should now pass. Then merge.