Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #127 update paralle write test to set table ids #128

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Fix #127 update paralle write test to set table ids #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63e220b
Fix #127 update paralle write test to set table ids
oruebel Oct 1, 2023
9215fe9
Merge branch 'dev' into fix/par_write_tests
mavaylon1 Oct 1, 2023
2ab6711
Update CHANGELOG
oruebel Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Enhanced ZarrIO to resolve object references lazily on read similar to HDMF's `HDF5IO` backend. @mavaylon1 [#120](https://github.com/hdmf-dev/hdmf-zarr/pull/120)

### New Features
* Added parallel write support for the ``ZarrIO`` for datasets wrapped with ``GenericDataChunkIterator``. @CodyCBakerPhD [#118](https://github.com/hdmf-dev/hdmf-zarr/pull/118)
* Added parallel write support for the ``ZarrIO`` for datasets wrapped with ``GenericDataChunkIterator``. @CodyCBakerPhD [#118](https://github.com/hdmf-dev/hdmf-zarr/pull/118) @oruebel [#128](https://github.com/hdmf-dev/hdmf-zarr/pull/128)

### Dependencies
* Updated HDMF and PyNWB version to the most recent release @mavaylon1 [#120](https://github.com/hdmf-dev/hdmf-zarr/pull/120)
Expand Down
12 changes: 10 additions & 2 deletions tests/unit/test_parallel_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,12 @@ def test_simple_tqdm(tmpdir):
display_progress=True,
)
)
dynamic_table = DynamicTable(name="TestTable", description="", columns=[column])
dynamic_table = DynamicTable(
name="TestTable",
description="",
columns=[column],
id=list(range(3)) # must provide id's when all columns are iterators
)
io.write(container=dynamic_table, number_of_jobs=number_of_jobs)

assert expected_desc in tqdm_out.getvalue()
Expand Down Expand Up @@ -222,7 +227,10 @@ def test_compound_tqdm(tmpdir):
)
)
dynamic_table = DynamicTable(
name="TestTable", description="", columns=[pickleable_column, not_pickleable_column]
name="TestTable",
description="",
columns=[pickleable_column, not_pickleable_column],
id=list(range(3)) # must provide id's when all columns are iterators
)
io.write(container=dynamic_table, number_of_jobs=number_of_jobs)

Expand Down
Loading