Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #127 update paralle write test to set table ids #128

Merged
merged 3 commits into from
Oct 1, 2023

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Oct 1, 2023

Motivation

Fix #127 update parallel write test to set table ids when all columns are iterators

How to test the behavior?

Run pytest on the dev branch using HDMF on dev

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e1a82e) 85.66% compared to head (2ab6711) 85.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #128   +/-   ##
=======================================
  Coverage   85.66%   85.66%           
=======================================
  Files          13       13           
  Lines        3139     3139           
=======================================
  Hits         2689     2689           
  Misses        450      450           
Files Coverage Δ
tests/unit/test_parallel_write.py 98.57% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor

@oruebel I'll approve this since the changes are minimal, but lets set up a time to talk about the parallel write after I take a look at what you and Cody have been doing.

@mavaylon1
Copy link
Contributor

@oruebel Do you need to update the changelog?

@oruebel
Copy link
Contributor Author

oruebel commented Oct 1, 2023

@oruebel Do you need to update the changelog?

Thanks @mavaylon1 . I updated the changlog. Since this PR only fixes an issue of a PR that is part of the same release, I only added an additional link to this PR for the corresponding item that was already in the CHANGLOG.

@mavaylon1 mavaylon1 merged commit e31f6a3 into dev Oct 1, 2023
21 checks passed
@mavaylon1 mavaylon1 deleted the fix/par_write_tests branch October 1, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Test for parallel write failing with HDMF dev
3 participants