Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No module named 'hdmf.array' #235

Closed
3 tasks done
yarikoptic opened this issue Nov 14, 2024 · 5 comments · Fixed by #236
Closed
3 tasks done

[Bug]: No module named 'hdmf.array' #235

yarikoptic opened this issue Nov 14, 2024 · 5 comments · Fixed by #236

Comments

@yarikoptic
Copy link

What happened?

in dandi-cli "dev" run where we test against development versions by doing

        pip install git+https://github.com/jaraco/keyring
        pip install git+https://github.com/NeurodataWithoutBorders/nwbinspector
        pip install git+https://github.com/NeurodataWithoutBorders/pynwb
        pip install git+https://github.com/hdmf-dev/hdmf

we started to fail with

___________________________ test_validate_nwb_error ____________________________
dandi/tests/test_validate.py:16: in test_validate_nwb_error
    assert len([i for i in validation_result if i.severity]) > 0
dandi/tests/test_validate.py:16: in <listcomp>
    assert len([i for i in validation_result if i.severity]) > 0
dandi/validate.py:161: in validate
    yield from df.get_validation_errors(
dandi/files/bases.py:512: in get_validation_errors
    from nwbinspector import Importance, inspect_nwbfile, load_config
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/nwbinspector/__init__.py:6: in <module>
    from ._nwb_inspection import (
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/nwbinspector/_nwb_inspection.py:17: in <module>
    from .tools._read_nwbfile import read_nwbfile, read_nwbfile_and_io
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/nwbinspector/tools/__init__.py:3: in <module>
    from ._read_nwbfile import BACKEND_IO_CLASSES, read_nwbfile, read_nwbfile_and_io
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/nwbinspector/tools/_read_nwbfile.py:9: in <module>
    from hdmf_zarr import NWBZarrIO
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/hdmf_zarr/__init__.py:1: in <module>
    from .backend import ZarrIO
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/hdmf_zarr/backend.py:24: in <module>
    from .zarr_utils import BuilderZarrReferenceDataset, BuilderZarrTableDataset
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/hdmf_zarr/zarr_utils.py:14: in <module>
    from hdmf.array import Array
E   ModuleNotFoundError: No module named 'hdmf.array'

Steps to Reproduce

#!/bin/bash
set -ex

cd "$(mktemp -d ${TMPDIR:-/tmp}/nwb-XXXXXXX)"


d=venvs/dev3; 
python3 -m venv $d && source $d/bin/activate 


python -m pip install --upgrade pip

pip install nwbinspector

pip install git+https://github.com/jaraco/keyring
pip install git+https://github.com/NeurodataWithoutBorders/nwbinspector
pip install git+https://github.com/NeurodataWithoutBorders/pynwb
pip install git+https://github.com/hdmf-dev/hdmf

python -c 'import nwbinspector'

reproduces it on my laptop with py 3.12



### Traceback

```shell
above

Operating System

Linux

Python Executable

Python

Python Version

3.12

Package Versions

No response

Code of Conduct

@mavaylon1
Copy link
Contributor

@yarikoptic Array has been deprecated and removed. We are about to do a major release for HDMF. https://github.com/hdmf-dev/hdmf/blob/dev/CHANGELOG.md

@yarikoptic
Copy link
Author

and that would break current hdmf-zarr which isn't yet adjusted for that?

@mavaylon1
Copy link
Contributor

@yarikoptic hdmf-zarr will have a major release next week

@yarikoptic
Copy link
Author

@yarikoptic hdmf-zarr will have a major release next week

That is great to hear but meanwhile issue remains not fixed -- reproducer keeps reproducing which is breaking our CI

@rly
Copy link
Contributor

rly commented Nov 21, 2024

This should be resolved when hdmf-zarr is released. The dev branch is up-to-date and cross-compatible with pynwb and hdmf. If you add pip install git+https://github.com/hdmf-dev/hdmf-zarr to your CI, I think that should resolve the issue until the hdmf-zarr release.

yarikoptic added a commit to dandi/dandi-cli that referenced this issue Nov 27, 2024
This should resolve our current failure due to No module named hdmf.array

Closes #1541
Ref: hdmf-dev/hdmf-zarr#235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants