Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to hdmf.Array and region references #236

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Remove references to hdmf.Array and region references #236

merged 6 commits into from
Nov 18, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 15, 2024

Motivation

Address hdmf.Array deprecation. Fix #235

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (b69c3e0) to head (f423f41).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #236      +/-   ##
==========================================
+ Coverage   85.58%   86.36%   +0.77%     
==========================================
  Files           5        5              
  Lines        1214     1188      -26     
  Branches      304      297       -7     
==========================================
- Hits         1039     1026      -13     
+ Misses        113      103      -10     
+ Partials       62       59       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/hdmf_zarr/backend.py Outdated Show resolved Hide resolved
@rly rly requested a review from mavaylon1 November 15, 2024 03:02
@rly rly changed the title Update zarr_utils.py to remove reference to hdmf.Array Remove references to hdmf.Array and region references Nov 15, 2024
@rly rly enabled auto-merge (squash) November 15, 2024 03:21
@rly rly merged commit 5a9055d into dev Nov 18, 2024
23 checks passed
@rly rly deleted the rly-patch-2 branch November 18, 2024 23:49
@rly rly mentioned this pull request Nov 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No module named 'hdmf.array'
3 participants