Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field search is broken #32

Closed
acka47 opened this issue Oct 13, 2017 · 4 comments
Closed

Field search is broken #32

acka47 opened this issue Oct 13, 2017 · 4 comments
Assignees
@fsteeg
Labels
bug

Comments

@acka47
Copy link
Contributor

acka47 commented Oct 13, 2017

See e.g. http://test.lobid.org/gnd/search?q=*+AND+type:%22CorporateBody%22 where all GND resources are listed with those on top that contain "type" and something similar to "CorporateBody".
@acka47 acka47 added the bug label Oct 13, 2017
@acka47
Copy link
Contributor Author

acka47 commented Oct 16, 2017

Field search is not broken per see as I just learned responding to a question on twitter: https://twitter.com/herr_tu/status/919848128936849409

@fsteeg fsteeg added ready and removed ready labels Oct 16, 2017
fsteeg added a commit that referenced this issue Oct 17, 2017
@fsteeg
Improve boosting for name fields
eb6ea22 
Don't apply full queryString to preferredName field
See #32

But retain boosting, and add variantName field
See #20
fsteeg added a commit that referenced this issue Oct 17, 2017
@fsteeg
Improve boosting for name fields
912895d 
Don't apply full queryString to preferredName field
See #32

But retain boosting, and add variantName field
See #20
@fsteeg
Copy link
Member

fsteeg commented Oct 17, 2017

Deployed to test:

http://test.lobid.org/gnd/search?q=*+AND+type:%22CorporateBody%22
http://test.lobid.org/gnd/search?q=preferredName%3A%22Heine%2C+Heinrich%22

Root cause was a bad fix for #20, which caused the full query string to be applied to the preferredName field, resulting in hits with type in their name for the sample query above. This field query was only part of the complete query, so sometimes results were good.

@fsteeg fsteeg added review and removed working labels Oct 17, 2017
@fsteeg fsteeg assigned acka47 and ChristophEwertowski and unassigned fsteeg Oct 17, 2017
@acka47
Copy link
Contributor Author

acka47 commented Oct 17, 2017

+1 (But the order still changes when using a filter, see #28. Will have to address this at a later point.)

@acka47 acka47 removed their assignment Oct 17, 2017
@ChristophEwertowski
Copy link
Contributor

+1 Assigning it back to fsteeg for opening a pull request with the right, non-WIP-branch and assigning it to @dr0i.

@fsteeg fsteeg added deploy and removed review labels Oct 17, 2017
@fsteeg fsteeg mentioned this issue Oct 17, 2017
Closed
@fsteeg fsteeg closed this as completed in 2956f8c Oct 17, 2017
@fsteeg fsteeg removed the deploy label Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsteeg fsteeg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fsteeg @acka47 @ChristophEwertowski