Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering shouldn't alter ranking #28

Closed
acka47 opened this issue Sep 21, 2017 · 4 comments
Closed

Filtering shouldn't alter ranking #28

acka47 opened this issue Sep 21, 2017 · 4 comments
Assignees
@fsteeg

Comments

@acka47
Copy link
Contributor

acka47 commented Sep 21, 2017 •
edited by fsteeg
Loading

For example:

  1. http://test.lobid.org/gnd/search?q=* -> The first 10 hits are all persons starting with "G"
  2. Filter by Person -> Not only are the other entities filtered out but the ranking is changed. Now persons with "Person" in their name are shown on top of the list.

Probably the best way to handle this would be to use elasticsearch filters instead of queries for facetting, see https://www.elastic.co/guide/en/elasticsearch/reference/current/query-filter-context.html (as we do in OER World Map).

BTW, we do it like this in all our services...
@fsteeg fsteeg removed the enhancement label Oct 6, 2017
@acka47 acka47 mentioned this issue Oct 17, 2017
Closed
fsteeg added a commit that referenced this issue Oct 17, 2017
@fsteeg
Support filtered queries via filter=, use in facet
9b71b14 
See #28
fsteeg added a commit that referenced this issue Oct 17, 2017
@fsteeg
Remove optional format query parameter from facet links
27ccbf2 
See #28
@fsteeg
Copy link
Member

fsteeg commented Oct 17, 2017

Deployed to test: http://test.lobid.org/gnd/search, filter CorporateBody

@fsteeg fsteeg assigned acka47 and ChristophEwertowski and unassigned fsteeg Oct 17, 2017
@fsteeg fsteeg added the review label Oct 17, 2017
@fsteeg
Copy link
Member

fsteeg commented Oct 17, 2017 •
edited
Loading

(Difference in initial search in comparison to original sample link is due to query changes for #32).

@acka47
Copy link
Contributor Author

acka47 commented Oct 17, 2017

That was quick. +1

@acka47 acka47 removed their assignment Oct 17, 2017
@ChristophEwertowski
Copy link
Contributor

ChristophEwertowski commented Oct 17, 2017 •
edited
Loading

+1 There are two organisations which are typed as Person and therefore wrongly assigned. I forwarded it to the Verbundgruppe. Assigning it to fsteeg for opening pull request.

@fsteeg fsteeg added deploy and removed review labels Oct 17, 2017
@fsteeg fsteeg closed this as completed in 2956f8c Oct 17, 2017
@fsteeg fsteeg removed the deploy label Oct 17, 2017
fsteeg added a commit to hbz/lobid-resources that referenced this issue Dec 12, 2017
@fsteeg
Add filter query parameter supporting query string syntax
e64dd88 
Initial use case: restrict NWBib queries to NWBib titles

See:

hbz/nwbib#163
hbz/lobid-gnd#28
@fsteeg fsteeg mentioned this issue Dec 12, 2017
Merged
@acka47 acka47 mentioned this issue May 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsteeg fsteeg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fsteeg @acka47 @ChristophEwertowski