Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global antora file #386
Global antora file #386
Changes from 26 commits
a628b9d
fbbca51
ddbf816
0e16ef5
e68fc68
72d8482
40ddbe9
b46319d
aba5cb0
b935a50
603c385
872a006
af8e3b4
5cf206d
cc0381c
81f921c
345e7d3
e24c9f7
fad37e2
daa7290
7333de6
0825b5a
f1c8a85
1bc7426
fd89213
6c4c950
c4c5dac
5131589
3783e5d
53ef7b5
3fb1949
c89e05e
68753f3
b3bf74b
213cf73
0e4097f
eaa101d
8d3abf5
f493ec9
a9cb2d5
afe9b17
a13c98a
65e8f39
febdeb1
d590e4e
9414a5e
8e2aa83
c9e97f5
ddd09f4
edfe18b
08188bc
ab9fb67
2cb5938
d3dca0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also delete the definition from
package.json
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script load-check-links-playbook.js creates that
check-links-playbook.yml
but on the fly.But I also don't like that
check-links-local
references a non-existing file, so I will probably refactor this part in the further work...This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the plan is to share this with other repos, can we centralise it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some summary documentation would help on what this does at a high-level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do both: centralizing and docs after we approve that the whole idea is worth implementing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a polite way of me saying, I don't think I fully understand what this does