Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global antora file #386

Merged
merged 54 commits into from
Nov 15, 2024
Merged

Conversation

fantkolja
Copy link
Contributor

@fantkolja fantkolja commented Oct 16, 2024

Should be merged after hazelcast/hazelcast-docs#412

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for frosty-curran-1fc0c4 ready!

Name Link
🔨 Latest commit d3dca0e
🔍 Latest deploy log https://app.netlify.com/sites/frosty-curran-1fc0c4/deploys/6737313c1497ca0008f9eb61
😎 Deploy Preview https://deploy-preview-386--frosty-curran-1fc0c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JackPGreen JackPGreen self-requested a review October 29, 2024 15:33
.github/workflows/validate.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also delete the definition from package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script load-check-links-playbook.js creates that check-links-playbook.yml but on the fly.

But I also don't like that check-links-local references a non-existing file, so I will probably refactor this part in the further work...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the plan is to share this with other repos, can we centralise it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some summary documentation would help on what this does at a high-level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do both: centralizing and docs after we approve that the whole idea is worth implementing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some summary documentation would help on what this does at a high-level.

Will do both: centralizing and docs after we approve that the whole idea is worth implementing

That was a polite way of me saying, I don't think I fully understand what this does

@fantkolja fantkolja requested a review from JackPGreen November 14, 2024 12:23
@fantkolja fantkolja marked this pull request as ready for review November 14, 2024 12:23
@fantkolja fantkolja merged commit 88ad811 into hazelcast:main Nov 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants