-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global antora file #386
Global antora file #386
Conversation
✅ Deploy Preview for frosty-curran-1fc0c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…agement-center-docs into feature/global-antora-file
check-links-playbook.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also delete the definition from package.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script load-check-links-playbook.js creates that check-links-playbook.yml
but on the fly.
But I also don't like that check-links-local
references a non-existing file, so I will probably refactor this part in the further work...
load-check-links-playbook.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the plan is to share this with other repos, can we centralise it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some summary documentation would help on what this does at a high-level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do both: centralizing and docs after we approve that the whole idea is worth implementing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some summary documentation would help on what this does at a high-level.
Will do both: centralizing and docs after we approve that the whole idea is worth implementing
That was a polite way of me saying, I don't think I fully understand what this does
Should be merged after hazelcast/hazelcast-docs#412