docs: OpenApi Documentation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroChaparro
requested changes
Aug 31, 2023
There was a problem hiding this comment.
Nice advance 🚀, however, check the review comments and note that the following endpoints are missing:
- GET endpoint to list the files in a given location ✅ (See ListFileReq.java).
- GET endpoint to download the file with the given UUID ✅ (See DownloadFileReq.java).
- POST/PUT endpoint to share the given file with the given user ✅ (See ShareWithReq.java).
- POST/PUT/DELETE endpoint to un-share the given file with the given user ✅ (See UnShareWithReq.java).
- GET endpoint to see the list of users the given file is shared to ✅ (See SharedWithWhoReq.java).
|
@shoriwe Hi 👋🏽, is the |
You should now have write access to this repository too |
MiguelMRojas
force-pushed
the
docs/openapi
branch
from
1b30258 to
d76445f
Compare
@PedroChaparro Thanks for checking, I already made new changes, please could you check it? |
PedroChaparro
requested changes
Sep 1, 2023
Woynert
requested changes
Sep 2, 2023
Woynert
previously requested changes
Sep 2, 2023
PedroChaparro
approved these changes
Sep 2, 2023
MiguelMRojas
added a commit
that referenced
this pull request
Oct 8, 2023
* docs: OpenApi Specification (#9) * chore: Update docker-compose (#12) * chore: Add missing env variables and services to docker-compose * chore: Use worker default env variables * ci: Linter and formatter (#14) * chore: Add recommended vscode extensions * chore(deps): Install black formatter and ruff linter * style: Lint and format files * docs: Add linting and formatting commands to README * ci: Add linter and style checks to integration pipeline * feat: endpoint login (#15) * feat: endpoint challenge (#33) --------- Co-authored-by: Antonio Donis <[email protected]> Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include: