Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: endpoint login #15

Merged
merged 7 commits into from
Oct 4, 2023
Merged

feat: endpoint login #15

merged 7 commits into from
Oct 4, 2023

Conversation

MiguelMRojas
Copy link
Member

@MiguelMRojas MiguelMRojas commented Oct 3, 2023 •
edited
Loading

Closes #16

@PedroChaparro PedroChaparro added the feature A new feature label Oct 3, 2023
@PedroChaparro PedroChaparro linked an issue Oct 3, 2023 that may be closed by this pull request
feat: Login endpoint #16
Closed
@PedroChaparro
Copy link
Contributor

I'm going to convert this to a draft because there are no tests, and the CI checks are failing. Please mark it as ready when you think it's complete.

@PedroChaparro PedroChaparro marked this pull request as draft October 3, 2023 21:50
@shoriwe
Copy link
Member

shoriwe commented Oct 3, 2023

@Andre154 @MiguelMRojas Please review why this PR checks failed

@MiguelMRojas MiguelMRojas marked this pull request as ready for review October 4, 2023 20:43
@PedroChaparro
Copy link
Contributor

As the /pages/home/_view.py file could potentially become very large if you place all the endpoints in it, I've opened #19 to propose a basic folder organization.

@PedroChaparro
refactor: Use basic views and controllers structure (#19)
d6c0594 
* chore: Remove templates folder

* refactor: Use basic views and controllers folders

* chore: Remove old test
@MiguelMRojas
Copy link
Member Author

As the /pages/home/_view.py file could potentially become very large if you place all the endpoints in it, I've opened #19 to propose a basic folder organization.

Thank you very much for these contributions 🚀

PedroChaparro
PedroChaparro requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@PedroChaparro PedroChaparro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🚀, just a few changes.

src/controllers/_authentication_controllers.py Outdated Show resolved Hide resolved
src/controllers/_authentication_controllers.py Outdated Show resolved Hide resolved
PedroChaparro
PedroChaparro approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@PedroChaparro PedroChaparro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and merge :shipit:. Keep going, you start using this endpoint in the web client.

@MiguelMRojas MiguelMRojas merged commit 4921ca1 into dev Oct 4, 2023
@MiguelMRojas MiguelMRojas deleted the feat/post branch October 4, 2023 23:39
@PedroChaparro
Copy link
Contributor

PedroChaparro commented Oct 4, 2023 •
edited
Loading

@MiguelMRojas, please, create a pull request from dev to main with the following title: release: v0.0.5

@PedroChaparro PedroChaparro mentioned this pull request Oct 8, 2023
Merged
MiguelMRojas added a commit that referenced this pull request Oct 8, 2023
@MiguelMRojas @shoriwe @PedroChaparro
release: v0.0.7 (#34)
45d3519 
* docs: OpenApi Specification (#9)

* chore: Update docker-compose (#12)

* chore: Add missing env variables and services to docker-compose

* chore: Use worker default env variables

* ci: Linter and formatter (#14)

* chore: Add recommended vscode extensions

* chore(deps): Install black formatter and ruff linter

* style: Lint and format files

* docs: Add linting and formatting commands to README

* ci: Add linter and style checks to integration pipeline

* feat: endpoint login (#15)

* feat: endpoint challenge (#33)

---------

Co-authored-by: Antonio Donis <[email protected]>
Co-authored-by: Pedro Andrés Chaparro Quintero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroChaparro PedroChaparro PedroChaparro approved these changes

@AndreaVelasquezA AndreaVelasquezA Awaiting requested review from AndreaVelasquezA

Assignees

@MiguelMRojas MiguelMRojas

Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Login endpoint
3 participants
@MiguelMRojas @PedroChaparro @shoriwe