systemd integration #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When systemd restarts the transmission-openvpn container, it seems to
leave zombie processes as below.
$ ps uaxww | grep Z
root 1872 0.0 0.0 0 0 ? Z 08:58 0:00 [transmission-da] <defunct>
The zombies do appear to be cleaned up by restarting docker itself, or
by stopping the transmission-openvpn service.
This is an attempt to prevent zombies being spawned via Yelp's
dumb-init, which correctly handles the signals that PID1 gets.
See: https://github.com/Yelp/dumb-init
|
Nice! Would you mind putting the section in the readme at the end? It's a more specific use case than running it on your NAS, so I feel it should be further down the file. |
|
Doesn't matter, I'm going to do some adjustments on the README now anyways. I'll move it. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #69
README changes explaining about systemd integration.
Plus Dockerfile change to install and use Yelp's dumb-init to avoid zombies.
I notice that there is a new version of dumb-init release since I started using it 12 days ago but I left the Dockerfile with v1.0.1, as that's the one I've been testing.
Cheers,
Dave