-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would you be interested in documentation for systemd integration? #69
Comments
Hey Dave, and thanks. Yeah, that would be a great addition for the README. Just out of curiosity, how are you doing the restart on fail thing? Are you checking if the connection is working, or restart the container if it exits? Looking forward to your PR Kristian |
Currently it is just triggered by the container not being running, so won't pick up the case where the VPN isn't active inside the running container. |
Allright. Then you might be able to combine it with the --ping-exit option for OpenVPN. If you set openvpn to exit when ping fails, then the container will stop. Then if you run the container with --restart=always, it should be restarted every time it goes down. See #61. Was also thought to go into the README at some point :) |
The following Do you have any suggestions on the zombie process issue?
|
I tried switching the base image to https://github.com/phusion/baseimage-docker in the Dockerfile as that claimed to prevent zombie processes, but that didn't appear to work - looking back I think I missed the most important step with this however. Then I used https://github.com/Yelp/dumb-init in the Dockerfile, and that has worked so far. See the commit at d5ve@7fb222e |
Hey again! Sorry for the late reply, I've had an AFK week :) But cool, this looks good! I've seen people use the tini init system but had to read up on the dumb-init. Looks to be much of the same and it's probably a good idea to have a small init running to deal with some issues. I assume it's been running smoothly since you introduced dumb-init? If you could open a PR to the dev branch with this plus a readme section for the systemd service that would be awesome :) |
I have been having a lot of success running the container with --restart=always (as haugene mentioned). Is the purpose of the systemd script to catch the circumstance where the container is running, but not connected to the VPN? |
The container has been running reliably since I switched to dumb-init, and came up well and without zombies when I last restarted the box. @aaronblair The |
Documentation merged, closing this |
Hi,
Thanks for this very useful piece of software.
I've set up docker-transmission-openvpn as a systemd service so that it starts at boot time, and restarts if it fails.
Would it be useful for me to document this for addition to the README? If so, I'll raise a pull request.
Cheers,
Dave
The text was updated successfully, but these errors were encountered: