Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TigerVPN as a new Provider #28

Merged
merged 1 commit into from
Aug 18, 2015
Merged

Added TigerVPN as a new Provider #28

merged 1 commit into from
Aug 18, 2015

Conversation

tsromana
Copy link
Contributor

added Tiger vpn as the new OPENVPN provider

added Tiger vpn as the new OPENVPN provider
@@ -4,9 +4,12 @@ if [ "$OPENVPN_PROVIDER" = "BTGUARD" ]
then
echo "VPN PROVIDER: BTGUARD"
vpn_provider="btguard"
else
else if [ "$OPENVPN_PROVIDER" = "PIA" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For backwards compatibility PIA should probably be the "default" VPN provider and any new ones should be called out explicitly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a bad idea to just make $OPENVPN_PROVIDER a required input when running the container.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @dougnukem . Thinking something like:
if provider = btguard
else if provider = pia
else if ...
else echo "No valid provider given"; exit 1
fi

ish?
This will also be backward compatible as OPENVPN_PROVIDER is set to PIA in Dockerfile. Could of course remove the default and make provider a required input as well. Defaulting to PIA makes less sense when the number of providers grows...

haugene added a commit that referenced this pull request Aug 18, 2015
Added TigerVPN as a new Provider
@haugene haugene merged commit 203219a into haugene:dev Aug 18, 2015
@tsromana
Copy link
Contributor Author

hey sorry i did a spell error have opened a pull request with the correct filename

@haugene
Copy link
Owner

haugene commented Aug 19, 2015

I didn't see it either. Merged now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants