Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve OpenTelemetry trace spans and events #43

Merged
merged 1 commit into from
Mar 16, 2024
Merged

improve OpenTelemetry trace spans and events #43

merged 1 commit into from
Mar 16, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Mar 16, 2024

cherry-pick #42

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-sdk-go/cmd/ndc-go-sdk 74% ✔
github.com/hasura/ndc-sdk-go/connector 52% ➖
github.com/hasura/ndc-sdk-go/example/reference 63% ➖
github.com/hasura/ndc-sdk-go/internal 46% ➖
github.com/hasura/ndc-sdk-go/schema 39% ❌
github.com/hasura/ndc-sdk-go/utils 43% ➖
Summary 50% (3598 / 7131) ➖

Minimum allowed line rate is 40%

@hgiasac hgiasac merged commit d818655 into main Mar 16, 2024
2 checks passed
@hgiasac hgiasac deleted the improve-trace-status-and-attributes-cherry branch March 16, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hgiasac