Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve OpenTelemetry trace spans and events #42

Merged
merged 5 commits into from
Mar 16, 2024
Merged

improve OpenTelemetry trace spans and events #42

merged 5 commits into from
Mar 16, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Mar 16, 2024 •
edited
Loading

  • Replace JSON request and response decoding spans to events
  • Fix OpenTelemetry endpoint parsing bug
  • Add more span events to help debug

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-sdk-go/cmd/ndc-go-sdk 74% ✔
github.com/hasura/ndc-sdk-go/connector 53% ➖
github.com/hasura/ndc-sdk-go/example/reference 63% ➖
github.com/hasura/ndc-sdk-go/internal 46% ➖
github.com/hasura/ndc-sdk-go/schema 39% ❌
github.com/hasura/ndc-sdk-go/utils 43% ➖
Summary 51% (3608 / 7127) ➖

Minimum allowed line rate is 40%

@hgiasac hgiasac merged commit 689c974 into v0 Mar 16, 2024
2 checks passed
@hgiasac hgiasac deleted the improve-trace-status-and-attributes branch March 16, 2024 16:57
@hgiasac hgiasac mentioned this pull request Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hgiasac