Create fallback page for iOS browsers failing to open Tailscale login page #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
stale
frenck
removed
the
stale
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
stale
|
Not stale. |
github-actions
bot
removed
the
stale
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
stale
|
Still not stale. |
github-actions
bot
removed
the
stale
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
stale
|
Still not stale. |
github-actions
bot
removed
the
stale
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
stale
|
not stale |
github-actions
bot
removed
the
stale
frenck
added
the
enhancement
frenck
reviewed
Oct 15, 2023
frenck
approved these changes
Oct 15, 2023
lmagyar
pushed a commit
to lmagyar/homeassistant-addon-tailscale
that referenced
this pull request
Oct 16, 2023
… page (hassio-addons#198) Co-authored-by: Franck Nijhof <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Modify nginx ingress JS replacement for rendered tailscale link pages to provide fallback on mobile for target=_blank links.
On iOS mobile, error page currently appears when clicking link to Tailscale.
If link fails to open, falls back to displaying URL to be copy-pasted into browser.
Related Issues