Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS native app currently incompatible with target=_blank links #157

Closed
bitfliq opened this issue Mar 25, 2023 · 3 comments · Fixed by #198
Closed

iOS native app currently incompatible with target=_blank links #157

bitfliq opened this issue Mar 25, 2023 · 3 comments · Fixed by #198
Labels
stale There has not been activity on this issue or PR for quite some time.

Comments

@bitfliq
Copy link
Contributor

bitfliq commented Mar 25, 2023

Problem/Motivation

iOS native app currently does not support target=_blank in window.open. This may also be an problem for native Safari browsing.
before

Related Issues

#103
home-assistant/iOS#2325

Expected behavior

Native app open url dialog is triggered or link is provided for user.

Actual behavior

Modal popup, "Failed to log in: null is not an object (evaluating 'window.open(url,"_blank").focus') (OK)

Previously referenced here:
#103

Steps to reproduce

Install Tailscale addon. Attempt to authenticate in to tailscale from iOS mobile app or mobile Safari.

Proposed changes

Modify JS to provide fallback. https://github.com/bitfliq/addon-tailscale/tree/main/tailscale
Desktop browser UX is unchanged. Fallback for mobile is this:
after

@sinclairpaul
Copy link
Member

Why wouldn't we just wait for the issue to be fixed upstream, rather than implementing a workaround that has to be removed in the future?, not sure of the benefit here.

@bitfliq
Copy link
Contributor Author

bitfliq commented Mar 26, 2023

(Previous comment deleted - Sorry @sinclairpaul! I was confused in replying to your message and thought this was the discussion thread I started for the iOS client. )

Yes, this would hopefully eventually be mitigated in the iOS client. This issue also happens for standalone mobile Safari, at least if HA is accessed over http. The addon already has one workaround for loading the tailscale auth website on desktop.

@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Apr 25, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale There has not been activity on this issue or PR for quite some time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants