Bump all packages to version 2.0.0.0 and prepare the release #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
requested review from
Anton-Latukha,
Ailrun,
ozkutuk,
uhbif19,
isovector,
konn,
kokobd,
pepeiborra,
santiweight,
OliverMadine,
eddiemundo,
berberman,
georgefst,
July541,
VeryMilkyJoe,
fendor and
drsooch
as code owners
wz1000
changed the title
July541
approved these changes
May 17, 2023
This simplifies the release process as we can bump all package versions in lockstep prior to a release instead of having to decide version bumps on a case to case basis while adhering to PVP. We don't test arbitrary configurations mixing versions of plugins/ghcide which you might get if you install HLS from hackage. With this in mind, it makes sense to pin the versions of all packages in this repository Exceptions include: - hie-compat (it is used by hiedb and is mostly separate from the other packages - it changes about once a GHC release) - shake-bench (not meant to be distributed for users, for internal testing only
michaelpj
approved these changes
May 17, 2023
georgefst
approved these changes
May 17, 2023
There was a problem hiding this comment.
Looks good, though I would be tempted to wait a day or two to see if there's a possibility of a new HLint release which we could include: ndmitchell/hlint#1477 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump all packages to version 2.0.0.0.
This simplifies the release process as we can bump all package versions in
lockstep prior to a release instead of having to decide version bumps on a case
to case basis while adhering to PVP.
We don't test arbitrary configurations mixing versions of plugins/ghcide which
you might get if you install HLS from hackage. With this in mind, it makes sense
to pin the versions of all packages in this repository
Exceptions include: