Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump HLS pin #995

Closed
wants to merge 1 commit into from
Closed

chore: bump HLS pin #995

wants to merge 1 commit into from

Conversation

dhess
Copy link
Member

@dhess dhess commented May 16, 2023

Signed-off-by: Drew Hess [email protected]

Signed-off-by: Drew Hess <[email protected]>
@georgefst
Copy link
Contributor

Unfortunately this doesn't solve the issue I've been seeing since upgrading to GHC 9.4.4 (on both my Hackworth Macbook with Nix, and my personal Linux machine without) where I see hundreds of spurious "overlapping instances" errors, even after clearing ~/.cache/ghcide/ and ~/.cache/hie-bios/.

I'll try to narrow this down and open an upstream bug report, especially since they appear to be on the verge of a release: haskell/haskell-language-server#3599.

Anyway, this PR doesn't make anything worse.

@brprice
Copy link
Contributor

brprice commented May 17, 2023

spurious "overlapping instances" errors

Is this another case of the old "package A depends on B which depends on C; if you load a file from A & C but not B, then you get strange errors" issue (I cannot immediately find the upstream bug report for this)?

For example, I get spurious overlapping instance errors from haskell-language-server primer/src/Primer/Core.hs primer/test/Tests/Action.hs, but not from haskell-language-server primer/src/Primer/Core.hs primer/test/Tests/Action.hs primer/gen/Tasty.hs primer/testlib/Primer/Test/TestM.hs

Perhaps the upstream issue haskell/haskell-language-server#3422 is relevant?

@dhess
Copy link
Member Author

dhess commented May 17, 2023

I don't think there's any point in merging this, then?

@georgefst
Copy link
Contributor

georgefst commented May 17, 2023

Is this another case of the old "package A depends on B which depends on C; if you load a file from A & C but not B, then you get strange errors" issue (I cannot immediately find the upstream bug report for this)?

Ah, thanks, yes it is! I was thrown off the scent by the fact this manifests quite differently to in pre-GHC-9.4, and I hadn't been using my load-all-components command from #181 (comment) (see various linked issues from that thread for the upstream discussions) due to haskell/haskell-language-server#3513, and had forgotten about primer/gen.

@dhess
Copy link
Member Author

dhess commented May 19, 2023

2.0 is out, hopefully we can build it with haskell.nix as soon as tonight's Hackage bump.

@dhess dhess closed this May 19, 2023
@dhess dhess deleted the dhess/bump-hls branch May 19, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants