fix incomplete-uni-patterns warnings
#1176
Conversation
the `flake.nix` build fails on these warnings: haskell#1154
exes/Main.hs
Outdated
| checkHostURI defaults Nothing port = do | ||
| let guessURI = confHostUri defaults | ||
| Just authority = uriAuthority guessURI | ||
| case uriAuthority guessURI of | ||
| Nothing -> fail "No URI Authority" |
There was a problem hiding this comment.
this new fail is the only change in this PR which might have some effect, is this acceptable?
There was a problem hiding this comment.
Why not simply disable the warning also in this case?
Is there evidence that this Just match can actually fail?
NB: Ideally unexpected failing matches would come with source location (HasCallStack).
There was a problem hiding this comment.
No problem, reverted the changes and applied the pragma, like the other files
It was the easiest of the warnings to fix, and using fail is consistent with the rest of the file IMO
There is no evidence the Just match can actually fail
exes/Main.hs
Outdated
| checkHostURI defaults Nothing port = do | ||
| let guessURI = confHostUri defaults | ||
| Just authority = uriAuthority guessURI | ||
| case uriAuthority guessURI of | ||
| Nothing -> fail "No URI Authority" |
There was a problem hiding this comment.
Why not simply disable the warning also in this case?
Is there evidence that this Just match can actually fail?
NB: Ideally unexpected failing matches would come with source location (HasCallStack).
peterbecich
changed the title
incomplete-uni-patterns warning, ignore some othersincomplete-uni-patterns warning
peterbecich
changed the title
incomplete-uni-patterns warningincomplete-uni-patterns warnings
|
Thanks @peterbecich ! |
the
flake.nixbuild fails on these warnings: #1154No effective changes in this PR